assets: replace embedded base64 blobs with plain files and template encoding#186
Merged
openshift-merge-bot[bot] merged 1 commit intoMay 26, 2026
Conversation
Member
Author
|
/rebase |
…ncoding Extract the three opaque base64/gzip payloads from 01-swap-enable.yaml into readable plain-text files under assets/active/machine-config/01-swap-enable/. Convert the asset to a template that encodes them at render time via readAsset | b64enc (kubelet config) and readAsset | gzip | b64enc (Python scripts). Add readAsset and gzip as custom template functions. readAsset is a package-level helper that reads directly from the embedded FS, prepending active/ internally so templates use clean relative paths. gzip is needed because sprig v3.3.0 does not include it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
enp0s3
approved these changes
May 26, 2026
Member
enp0s3
left a comment
enp0s3
left a comment
There was a problem hiding this comment.
@tiraboschi Looks good to me, thank you!
/lgtm
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 5ea98fb
into
openshift-virtualization:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the three opaque base64/gzip payloads from 01-swap-enable.yaml into readable plain-text files under
assets/active/machine-config/01-swap-enable/. Convert the asset to a template that encodes them at render time via readAsset | b64enc (kubelet config) and readAsset | gzip | b64enc (Python scripts).Add
readAssetand gzip as custom template functions.readAssetis a package-level helper that reads directly from the embedded FS, prepending active/ internally so templates use clean relative paths. gzip is needed because sprig v3.3.0 does not include it.