-
Notifications
You must be signed in to change notification settings - Fork 116
fix: Set tektonhub as the default catalog type for custom Hub URLs #2351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @pratap0007, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where custom Hub URLs were incorrectly defaulting to the "ArtifactHubType" catalog. The change introduces logic to automatically set the catalog type to "TektonHubType" when a non-default Hub URL is detected, improving the system's ability to correctly interpret and utilize custom hub configurations. This ensures that users leveraging custom hubs experience the intended Tekton Hub functionality by default. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
π PR Lint Feedback
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly changes the default catalog type to TektonHubType when a custom Hub URL is provided, instead of ArtifactHubType. The accompanying unit tests have been updated appropriately to validate this new default behavior. My review includes one suggestion to simplify the conditional logic for better readability and maintainability.
When a custom hub URL is configured, default the catalog type to TektonHubType instead of ArtifactHubType. Signed-off-by: Shiv Verma <shverma@redhat.com>
ebeafda to
bc2b3a5
Compare
|
/retest |
When a custom hub URL is configured, default the catalog type to TektonHubType instead of ArtifactHubType.
Fixes: SRVKP-9248
π Description of the Change
π¨π»β Linked Jira
π Linked GitHub Issue
Fixes #
π Type of Change
fix:)feat:)feat!:,fix!:)docs:)chore:)refactor:)enhance:)deps:)π§ͺ Testing Strategy
π€ AI Assistance
If you have used AI assistance, please provide the following details:
Which LLM was used?
Extent of AI Assistance:
Important
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Gemini gemini@google.com
Co-authored-by: ChatGPT noreply@chatgpt.com
Co-authored-by: Claude noreply@anthropic.com
Co-authored-by: Cursor noreply@cursor.com
Co-authored-by: Copilot Copilot@users.noreply.github.com
**π‘You can use the script
./hack/add-llm-coauthor.shto automatically addthese co-author trailers to your commits.
β Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.