Bump google.golang.org/api from 0.257.0 to 0.269.0#1027
Conversation
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughBump Go toolchain from go1.24.13 to go1.25.0 and update direct and indirect dependency versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a openshift-online member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 3: go.mod currently declares "go 1.25.0" which conflicts with CI that
only tests Go 1.22–1.23; either update the CI matrices to include Go 1.25 or
downgrade the module version to the lowest tested version. Fix option A: add
"1.25" to the Go version lists in the workflow files referenced
(check-pull-request.yaml and publish-release.yaml) so CI covers 1.22, 1.23, and
1.25; or Fix option B: change the go directive in go.mod from 1.25.0 back to
1.22 to match the existing CI matrix. Ensure the chosen change is applied
consistently across go.mod and the GitHub Actions workflow matrices.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| module github.com/openshift-online/ocm-cli | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether repository tooling and CI are aligned with Go 1.25.0
set -euo pipefail
echo "== go.mod directive =="
rg -n '^go\s+[0-9]+\.[0-9]+(\.[0-9]+)?$' go.mod
echo
echo "== CI / workflow Go versions =="
fd -H -t f '.*\.(yml|yaml)$' .github/workflows 2>/dev/null | xargs -r rg -n 'go-version|setup-go|golang:|GOTOOLCHAIN|GO_VERSION' || echo "No matches found"
echo
echo "== Docker/Container Go base images =="
fd -H -t f 'Dockerfile.*|Dockerfile' . 2>/dev/null | xargs -r rg -n 'golang:[0-9]+\.[0-9]+' || echo "No matches found"
echo
echo "== Makefile / scripts pinned Go versions =="
fd -H -t f 'Makefile|.*\.mk|.*\.sh' . 2>/dev/null | xargs -r rg -n '1\.24|1\.25|GO_VERSION|GOTOOLCHAIN|go[[:space:]]+test|go[[:space:]]+build' || echo "No matches found"Repository: openshift-online/ocm-cli
Length of output: 834
🏁 Script executed:
#!/bin/bash
# Check recent commits and PR description for context
echo "== Recent commits touching go.mod =="
git log --oneline -10 -- go.mod 2>/dev/null || echo "Git history unavailable"
echo
echo "== Full go.mod first 20 lines =="
head -20 go.modRepository: openshift-online/ocm-cli
Length of output: 843
Resolve Go version mismatch: go.mod declares 1.25.0 but CI tests only 1.22–1.23
Line 3 sets go 1.25.0 as the module minimum, yet CI workflows test only against Go 1.22 and 1.23. This violates Go module semantics—the declared minimum must match the lowest tested version. Either:
- Add Go 1.25 to the CI test matrix (check-pull-request.yaml and publish-release.yaml), or
- Revert go.mod to
go 1.22(the actual minimum tested version)
This change appears unintentional; the commit bumps google.golang.org/api dependency only.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 3, go.mod currently declares "go 1.25.0" which conflicts with
CI that only tests Go 1.22–1.23; either update the CI matrices to include Go
1.25 or downgrade the module version to the lowest tested version. Fix option A:
add "1.25" to the Go version lists in the workflow files referenced
(check-pull-request.yaml and publish-release.yaml) so CI covers 1.22, 1.23, and
1.25; or Fix option B: change the go directive in go.mod from 1.25.0 back to
1.22 to match the existing CI matrix. Ensure the chosen change is applied
consistently across go.mod and the GitHub Actions workflow matrices.
openshift-merge-robot
added
the
needs-rebase
|
rebase DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.257.0 to 0.269.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.257.0...v0.269.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.269.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/google.golang.org/api-0.269.0
branch
from
4411e06 to
50eb178
Compare
openshift-merge-robot
removed
the
needs-rebase
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
3-3:⚠️ Potential issue | 🟠 MajorGo version mismatch: go.mod declares 1.25.0 but CI likely tests older versions
The Go toolchain has been bumped to 1.25.0, but this may be inconsistent with the CI test matrix which likely tests against Go 1.22 and 1.23 only. This mismatch violates Go module semantics where the declared minimum version should match the lowest tested version.
Either add Go 1.25 to the CI workflow matrices, or revert the
godirective to match the minimum version actually tested in CI. This change appears incidental to the google.golang.org/api dependency bump and may be unintentional.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 3, The go.mod "go" directive was bumped to 1.25.0 but CI likely still tests older Go versions; either update CI workflows to include Go 1.25 in the matrix, or revert the go.mod directive back to the minimum Go version supported by CI (e.g., 1.22 or 1.23) so the declared module version matches the lowest tested version; locate and modify the "go 1.25.0" directive in go.mod or update the CI matrix entries that reference tested Go versions to include 1.25.0 accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@go.mod`:
- Line 3: The go.mod "go" directive was bumped to 1.25.0 but CI likely still
tests older Go versions; either update CI workflows to include Go 1.25 in the
matrix, or revert the go.mod directive back to the minimum Go version supported
by CI (e.g., 1.22 or 1.23) so the declared module version matches the lowest
tested version; locate and modify the "go 1.25.0" directive in go.mod or update
the CI matrix entries that reference tested Go versions to include 1.25.0
accordingly.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
|
Superseded by #1050. |
dependabot
Bot
deleted the
dependabot/go_modules/google.golang.org/api-0.269.0
branch
1 participant
Bumps google.golang.org/api from 0.257.0 to 0.269.0.
Release notes
Sourced from google.golang.org/api's releases.
... (truncated)
Changelog
Sourced from google.golang.org/api's changelog.
... (truncated)
Commits
312ac01chore(main): release 0.268.1 (#3513)7565f1cfeat(all): auto-regenerate discovery clients (#3512)2a249cefix(generator): handle preview version pkg name (#3511)26ea889chore(all): update all (#3498)5b078d9chore(main): release 0.268.0 (#3503)20c1e0ffeat(all): auto-regenerate discovery clients (#3509)20fbcc1feat(all): auto-regenerate discovery clients (#3508)e9015ccfeat(all): auto-regenerate discovery clients (#3507)cc5baecfeat: update to go 1.26 (#3504)cda923afeat(all): auto-regenerate discovery clients (#3506)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)