Skip to content

OCPBUGS-78998: Handle agent OVE UI Manifests page#1871

Open
bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
bfournie:agent-ove-ui-manifests
Open

OCPBUGS-78998: Handle agent OVE UI Manifests page#1871
bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
bfournie:agent-ove-ui-manifests

Conversation

@bfournie
Copy link
Contributor

@bfournie bfournie commented Mar 20, 2026 •
edited
Loading

For the UI-drive installation handle the Cluster Manifests page.

This handles both 4.22+, where the page exists, and 4.21 where the page does not exist.

@openshift-ci openshift-ci bot requested review from celebdor and rwsu March 20, 2026 20:02
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign celebdor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
OCPBUGS-78998: Handle agent OVE UI Manifests page
4bc4a1e 
For the UI-drive installation handle the Cluster Manifests page.
This is currently breaking 4.22, if the UI change is backported
to 4.21 then we won't need a version check in dev-scripts.
@bfournie bfournie force-pushed the agent-ove-ui-manifests branch from b2955cb to 4bc4a1e Compare March 23, 2026 15:16
@bfournie
Copy link
Contributor Author

bfournie commented Mar 23, 2026

Testing of 4.22 is currently in progress.

For 4.21 I verified it locally:

time="2026-03-23T16:03:20+01:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/06-credentials.png, with type of image/png"
time="2026-03-23T16:03:25+01:00" level=info msg="No Custom manifests page (OCP < 4.22), already on review page"
time="2026-03-23T16:03:25+01:00" level=info msg="Review and start cluster installation"

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2026

@bfournie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 4bc4a1e link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rwsu
rwsu reviewed Mar 23, 2026
View reviewed changes
agent/isobuilder/ui_driven_cluster_installation/main.go
Comment on lines +131 to +132
logrus.Info("Custom manifests page detected (OCP 4.22+)")
err = saveFullPageScreenshot(page, filepath.Join(screenshotPath, fmt.Sprintf("%02d-custom-manifests.png", stepNum)))
Copy link
Contributor

@rwsu rwsu Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a "tab" here. Cluster installation did start, so this PR is fixing the issue. The post verification test timed out and that is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

1 more reviewer

@rwsu rwsu rwsu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bfournie @rwsu