Skip to content

fix grafana-dash-knative-eventing-channel query for kafkachannels#4107

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:mainfrom
maschmid:maschmid-fix-knative-eventing-channel-dashboard-query
May 18, 2026
Merged

fix grafana-dash-knative-eventing-channel query for kafkachannels#4107
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:mainfrom
maschmid:maschmid-fix-knative-eventing-channel-dashboard-query

Conversation

@maschmid
Copy link
Copy Markdown
Contributor

kn_eventing_dispatch_latency_ms_count has kn_kafkachannel_namespace ,
kn_eventing_dispatch_duration_seconds_count has kn_channel_namespace

So when using just kn_channel_namespace labels, we don't see the kafkachannel namespaces.

Use label_replace to rename the kn_kafkachannel_namespace labels to kn_channel_namespace for the namespace query.

  • 🧹 fix grafana-dash-knative-eventing-channel query for kafkachannels

@maschmid maschmid requested a review from creydr May 13, 2026 13:01
@openshift-ci openshift-ci Bot requested review from Kaustubh-pande and aliok May 13, 2026 13:01
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@maschmid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/421-mesh-upgrade 66f145a link false /test 421-mesh-upgrade
ci/prow/420-kitchensink-upgrade 66f145a link false /test 420-kitchensink-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 14d5a64 into openshift-knative:main May 18, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants