Skip to content

move slack reporter from prowgen config to test#968

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:mainfrom
maschmid:maschmid-move-slack-notification-from-prowgen-config
May 18, 2026
Merged

move slack reporter from prowgen config to test#968
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:mainfrom
maschmid:maschmid-move-slack-notification-from-prowgen-config

Conversation

@maschmid
Copy link
Copy Markdown
Contributor

No description provided.

@maschmid maschmid requested a review from dsimansk May 18, 2026 08:09
@openshift-ci openshift-ci Bot requested review from Kaustubh-pande and matzew May 18, 2026 08:09
@maschmid
Copy link
Copy Markdown
Contributor Author

DNM rehearse test opened openshift/release#79391

@dsimansk
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit ddeab51 into openshift-knative:main May 18, 2026
4 checks passed
Comment thread pkg/prowgen/prowgen.go
Comment on lines +345 to +348
reporterConfig := map[string]interface{}{
"channel": slackChannel,
"job_states_to_report": []interface{}{"success", "failure", "error"},
"report_template": slackReportTemplate,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maschmid would updating ci-tools library bring new structure with "official" support of reporters etc.?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, let's do that #969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants