Update google.golang.org/genproto/googleapis/rpc digest to 3700d41#114
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 139: The require entry for module
google.golang.org/genproto/googleapis/rpc uses a bare commit hash (3700d4141b60)
which is invalid; change it to a proper semantic or pseudo-version like the
neighboring genproto entries (e.g., v0.0.0-<timestamp>-3700d4141b60) so go mod
can resolve it—update the module version for
google.golang.org/genproto/googleapis/rpc to the matching pseudo-version format
used elsewhere.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 879de028-5690-4f29-8850-0866a419f79a
📒 Files selected for processing (1)
go.mod
| google.golang.org/genproto v0.0.0-20260209200024-4cfbd4190f57 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20260401024825-9d38bb4040a9 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20260401024825-9d38bb4040a9 // indirect | ||
| google.golang.org/genproto/googleapis/rpc 3700d4141b60 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Checking Line with googleapis/rpc in go.mod:"
rg -n 'google\.golang\.org/genproto/googleapis/rpc' go.mod
python - <<'PY'
import re, pathlib, sys
content = pathlib.Path("go.mod").read_text()
m = re.search(r'google\.golang\.org/genproto/googleapis/rpc\s+(\S+)', content)
if not m:
print("Entry not found")
sys.exit(2)
version = m.group(1)
print("Detected version:", version)
# Accept semver or Go pseudo-version.
semver = re.compile(r'^v\d+\.\d+\.\d+(?:[-+][0-9A-Za-z.-]+)?$')
pseudo = re.compile(r'^v\d+\.\d+\.\d+-\d{14}-[0-9a-f]{12}$')
if semver.match(version) or pseudo.match(version):
print("Version format looks valid.")
sys.exit(0)
print("Invalid Go module version format for go.mod require directive.")
sys.exit(1)
PYRepository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 295
🏁 Script executed:
#!/bin/bash
# Read the go.mod context around line 139 to see nearby versions and patterns
echo "=== Context around line 139 in go.mod ==="
sed -n '130,150p' go.mod
# Also check if there's any pattern or comment about this change
echo -e "\n=== Checking for any nearby comments or patterns ==="
sed -n '135,145p' go.mod
# Get full file to check for other genproto entries
echo -e "\n=== All genproto entries in go.mod ==="
rg 'genproto' go.mod -n || trueRepository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 1532
Fix the invalid Go module version format at line 139.
3700d4141b60 is a bare commit hash and not a valid Go module version. The require directive must use a proper semantic version (e.g., v1.2.3) or pseudo-version format (e.g., v0.0.0-<timestamp>-3700d4141b60). This will cause go mod resolution to fail and block builds. Correct this to match the proper pseudo-version format used by neighboring genproto entries.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 139, The require entry for module
google.golang.org/genproto/googleapis/rpc uses a bare commit hash (3700d4141b60)
which is invalid; change it to a proper semantic or pseudo-version like the
neighboring genproto entries (e.g., v0.0.0-<timestamp>-3700d4141b60) so go mod
can resolve it—update the module version for
google.golang.org/genproto/googleapis/rpc to the matching pseudo-version format
used elsewhere.
This PR contains the following updates:
9d38bb4→3700d41Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.