Update google.golang.org/genproto digest to 3700d41#112
Open
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Open
Update google.golang.org/genproto digest to 3700d41#112red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Author
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThis pull request updates a single indirect dependency in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 137: The go.mod entry for the module identifier
google.golang.org/genproto is using a raw commit digest (3700d4141b60) which is
invalid; replace that digest with a valid Go pseudo-version or an official
tagged release for google.golang.org/genproto (e.g.
v0.0.0-<timestamp>-3700d4141b60) or run `go get
google.golang.org/genproto@latest`/a specific tagged version to let Go generate
the correct pseudo-version and update the go.mod entry accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 3cd8f4dd-043d-4d1e-895d-f6322c13e615
📒 Files selected for processing (1)
go.mod
| golang.org/x/time v0.14.0 // indirect | ||
| google.golang.org/api v0.266.0 // indirect | ||
| google.golang.org/genproto v0.0.0-20260209200024-4cfbd4190f57 // indirect | ||
| google.golang.org/genproto 3700d4141b60 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify go.mod require lines that have invalid version format
# Expected: no output for valid files.
awk '
BEGIN { in_require=0 }
/^\s*require\s*\(/ { in_require=1; next }
in_require && /^\s*\)/ { in_require=0; next }
in_require {
# strip inline comments
line=$0
sub(/[[:space:]]*\/\/.*$/, "", line)
# module + version pattern
if (match(line, /^[[:space:]]*([^[:space:]]+)[[:space:]]+([^[:space:]]+)[[:space:]]*$/, m)) {
mod=m[1]; ver=m[2]
# valid: semver vX.Y.Z(-suffix) OR pseudo-version vX.0.0-yyyymmddhhmmss-<12+hex>
if (ver !~ /^v[0-9]+\.[0-9]+\.[0-9]+([\-+].*)?$/ &&
ver !~ /^v[0-9]+\.[0-9]+\.[0-9]+-[0-9]{14}-[0-9a-f]{12,}$/) {
printf("Invalid version format: %s %s\n", mod, ver)
}
}
}
' go.modRepository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 148
🏁 Script executed:
#!/bin/bash
# Check the actual state of go.mod around line 137
echo "=== Lines 130-145 of go.mod ==="
sed -n '130,145p' go.mod
echo -e "\n=== Checking all google.golang.org/genproto entries ==="
grep -n "google.golang.org/genproto" go.modRepository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 1049
🏁 Script executed:
#!/bin/bash
# Check git diff to see what changed in go.mod
echo "=== Git diff for go.mod (if available) ==="
git diff HEAD~1 go.mod 2>/dev/null | grep -A 3 -B 3 "google.golang.org/genproto" || echo "No git history available"
echo -e "\n=== Check if this is a valid commit hash format ==="
# 3700d4141b60 is 12 hex characters (short commit hash)
# But Go modules need the full version format
echo "Format analysis:"
echo "- Found: 3700d4141b60 (12 hex chars - looks like git short commit hash)"
echo "- Expected for go.mod: v0.0.0-<timestamp>-<12hex> format"
echo "- Similar to: v0.0.0-20260401024825-9d38bb4040a9"Repository: openshift-hyperfleet/hyperfleet-sentinel
Length of output: 400
Use a valid Go module version format for google.golang.org/genproto.
Line 137 uses a raw commit digest (3700d4141b60) instead of a valid pseudo-version (v0.0.0-<timestamp>-<commit>). This violates Go module specification and will cause module resolution and dependency operations to fail.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 137, The go.mod entry for the module identifier
google.golang.org/genproto is using a raw commit digest (3700d4141b60) which is
invalid; replace that digest with a valid Go pseudo-version or an official
tagged release for google.golang.org/genproto (e.g.
v0.0.0-<timestamp>-3700d4141b60) or run `go get
google.golang.org/genproto@latest`/a specific tagged version to let Go generate
the correct pseudo-version and update the go.mod entry accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4cfbd41→3700d41Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.