Skip to content

Change ellipseID to ellipseId #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewbotts merged 3 commits into from
Apr 20, 2026
+2 −2
Merged

Change ellipseID to ellipseId #815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f688c45
Change ellipseID to ellipseId
philip-khaisman Mar 6, 2026
9de5f0a
Fix ellipse layer
philip-khaisman Mar 12, 2026
97af56e
Oops change back to ellipseId
philip-khaisman Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/core/ui/layer/EllipseLayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class EllipseLayer extends Layer {
* @param {Function} [properties.getSemiMinorAxis] - defines a function to return the semiMinorAxis
* @param {Function} [properties.getHeight] - defines a function to return the height of the ellipse above the ellipsoid
* @param {Function} [properties.getRotation] - defines a function to return the rotation of the ellipse
* @param {Function} [properties.getEllipseID] - map an id to a unique ellipse
* @param {Function} [properties.getEllipseId] - map an id to a unique ellipse
*/
constructor(properties) {
super(properties);
Expand Down Expand Up @@ -98,7 +98,7 @@ class EllipseLayer extends Layer {
props.zIndex = properties.zIndex;
}

this.definedId('ellipseID', props)
this.definedId('ellipseId', props)

if (isDefined(properties.getPosition)){
let fn = async (rec, timestamp, options) => {
Expand Down