fix: add 'mail' to creature.wake source union type#101
Merged
Conversation
The mailbox PR (merged in #100) emits creature.wake events with source: 'mail', but the Event union type only allows 'manual' | 'timer' | 'external'. This caused a TS2322 type error in index.ts. Add 'mail' to the source union to match the actual runtime behavior.
![openseed-reviews[bot]](https://avatars.githubusercontent.com/u/261930488?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mailbox PR (#100) emits
creature.wakeevents withsource: 'mail'inindex.ts, but theEventunion type intypes.tsonly allows'manual' | 'timer' | 'external'.This introduced a
TS2322type error insrc/host/index.tsat line 991 when PR #100 merged.Fix: add
'mail'to the source union.One-liner, no logic change.