Skip to content

Fix SemanticCheckException not thrown #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunil9977 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

Fix SemanticCheckException not thrown #5239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/java/org/opensearch/sql/analysis/AnalysisContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,11 @@ public TypeEnvironment pop() {
environment = curEnv.getParent();
return curEnv;
}

/**
* Push a new isolated environment without parent access.
*/
public void pushIsolated() {
environment = new TypeEnvironment(null);
}
}
2 changes: 1 addition & 1 deletion core/src/main/java/org/opensearch/sql/analysis/Analyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ public LogicalPlan visitProject(Project node, AnalysisContext context) {

child = processNestedAnalysis(node.getProjectList(), namedExpressions, child, context);

context.push();
context.pushIsolated();
TypeEnvironment newEnv = context.peek();
namedExpressions.forEach(
expr ->
Expand Down
3 changes: 0 additions & 3 deletions core/src/test/java/org/opensearch/sql/analysis/AnalyzerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,9 +898,6 @@ public void remove_source() {
AstDSL.field("double_value")));
}

@Disabled(
"the project/remove command should shrink the type env. Should be enabled once "
+ "https://github.com/opensearch-project/sql/issues/917 is resolved")
@Test
public void project_source_change_type_env() {
SemanticCheckException exception =
Expand Down
Loading