Skip to content

Sync up this path publish-async-query-core.yml from main to 2.19-dev and also changing the JAVA to 17 #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swiddis merged 1 commit into from
Jan 6, 2026
+17 −7
Merged

Sync up this path publish-async-query-core.yml from main to 2.19-dev and also changing the JAVA to 17 #4996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/publish-async-query-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ on:
push:
branches:
- main
- 1.*
- 2.*
- '[0-9]+.[0-9]+'
- '[0-9]+.x'
paths:
- 'async-query-core/**'
- '.github/workflows/publish-async-query-core.yml'
Expand All @@ -18,7 +18,6 @@ concurrency:
cancel-in-progress: false

env:
SNAPSHOT_REPO_URL: https://central.sonatype.com/repository/maven-snapshots/
COMMIT_MAP_FILENAME: commit-history-async-query-core.json

jobs:
Expand All @@ -36,7 +35,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 21
java-version: 17
Copy link
Member

@LantaoJin LantaoJin Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be 11 for 2.19?

Copy link
Author

@Parasjg Parasjg Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We connected with Kai Huang , he suggested 17 could work . Do let me know if we can't go ahead with this one.

Copy link
Contributor

@ahkcs ahkcs Jan 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use JDK 17 for async query core jar here and main branch doesn't support 17, that's why I suggested them to backport the maven snapshot upload logic to 2.19-dev branch with JDK 17 supported, please let me know if there's any concerns for this


- uses: actions/checkout@v3

Expand All @@ -47,8 +46,19 @@ jobs:
export-env: true
env:
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
SONATYPE_USERNAME: op://opensearch-infra-secrets/maven-central-portal-credentials/username
SONATYPE_PASSWORD: op://opensearch-infra-secrets/maven-central-portal-credentials/password
MAVEN_SNAPSHOTS_S3_REPO: op://opensearch-infra-secrets/maven-snapshots-s3/repo
MAVEN_SNAPSHOTS_S3_ROLE: op://opensearch-infra-secrets/maven-snapshots-s3/role

- name: Export SNAPSHOT_REPO_URL
run: |
snapshot_repo_url=${{ env.MAVEN_SNAPSHOTS_S3_REPO }}
echo "SNAPSHOT_REPO_URL=$snapshot_repo_url" >> $GITHUB_ENV

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v5
with:
role-to-assume: ${{ env.MAVEN_SNAPSHOTS_S3_ROLE }}
aws-region: us-east-1

- name: Set commit ID
id: set_commit
Expand Down
2 changes: 1 addition & 1 deletion async-query-core/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ check.dependsOn jacocoTestCoverageVerification

shadowJar {
archiveBaseName.set('async-query-core')
archiveVersion.set('1.0.0') // Set the desired version
archiveVersion.set('0.0.0.1') // Set the desired version
archiveClassifier.set('all')

from sourceSets.main.output
Expand Down
Loading