Remove GetAlias Call

[aparajita31pandey]

Description

Related Issues

Resolves

Check List

• New functionality includes testing.
• New functionality has been documented.
• New functionality has javadoc added.
• New functionality has a user manual doc added.
• New PPL command checklist all confirmed.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff or -s.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved index mapping resolution by enforcing single mapping requirement, providing clearer error handling when multiple mappings are encountered.
  • Removed previous alias resolution logic to streamline index lookup process.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Removed runtime alias resolution that used GetAliasesRequest/GetAliasesResponse and replaced flexible indexName-based mapping lookup with a strict single-entry requirement; type mappings are now obtained from the sole mapping entry via .values().iterator().next().

Changes

Cohort / File(s)	Summary
Alias resolution and mapping validation changes legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java	Deleted alias-remapping code that queried GetAliasesRequest/GetAliasesResponse; changed mapping validation to require exactly one entry (mappings.size() != 1 triggers error); switched type-mapping access to mappings.values().iterator().next(); removed related imports.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Verify callers/contexts guarantee a single mapping entry; confirm no callers rely on previous alias resolution behavior.
• Inspect error path for mappings.size() != 1 to ensure appropriate messaging and coverage.
• Confirm .values().iterator().next() is safe and deterministic in intended runtime environments.

Suggested labels

enhancement

Suggested reviewers

• penghuo
• ps48
• kavithacm
• derek-ho
• joshuali925
• anirudha
• LantaoJin
• yuancu

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Remove GetAlias Call' directly and clearly summarizes the main change: removing the GetAlias API call from the code.
Description check	✅ Passed	The description is related to the changeset, explaining the rationale for removing the alias resolution call and providing tested examples of the functionality.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09da047 and 86a52ba.

📒 Files selected for processing (1)

• legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java

🚧 Files skipped from review as they are similar to previous changes (1)

• legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)

• GitHub Check: build-linux (25, unit)
• GitHub Check: build-linux (21, unit)
• GitHub Check: build-linux (25, integration)
• GitHub Check: build-linux (25, doc)
• GitHub Check: build-linux (21, doc)
• GitHub Check: build-linux (21, integration)
• GitHub Check: bwc-tests-rolling-upgrade (25)
• GitHub Check: bwc-tests-full-restart (21)
• GitHub Check: bwc-tests-full-restart (25)
• GitHub Check: bwc-tests-rolling-upgrade (21)
• GitHub Check: security-it-linux (21)
• GitHub Check: security-it-linux (25)
• GitHub Check: build-windows-macos (macos-14, 21, integration)
• GitHub Check: build-windows-macos (macos-14, 25, unit)
• GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, unit)
• GitHub Check: build-windows-macos (macos-14, 21, doc)
• GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, integration)
• GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, unit)
• GitHub Check: build-windows-macos (macos-14, 25, integration)
• GitHub Check: build-windows-macos (macos-14, 25, doc)
• GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, integration)
• GitHub Check: build-windows-macos (macos-14, 21, unit)
• GitHub Check: security-it-windows-macos (macos-14, 21)
• GitHub Check: security-it-windows-macos (macos-14, 25)
• GitHub Check: security-it-windows-macos (windows-latest, 21)
• GitHub Check: security-it-windows-macos (windows-latest, 25)
• GitHub Check: test-sql-cli-integration (21)
• GitHub Check: CodeQL-Scan (java)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbcdbd6 and 09da047.

📒 Files selected for processing (1)

• legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java

🧰 Additional context used

📓 Path-based instructions (1)

**/*.java

📄 CodeRabbit inference engine (.rules/REVIEW_GUIDELINES.md)

**/*.java: Use PascalCase for class names (e.g., QueryExecutor)
Use camelCase for method and variable names (e.g., executeQuery)
Use UPPER_SNAKE_CASE for constants (e.g., MAX_RETRY_COUNT)
Keep methods under 20 lines with single responsibility
All public classes and methods must have proper JavaDoc
Use specific exception types with meaningful messages for error handling
Prefer Optional<T> for nullable returns in Java
Avoid unnecessary object creation in loops
Use StringBuilder for string concatenation in loops
Validate all user inputs, especially queries
Sanitize data before logging to prevent injection attacks
Use try-with-resources for proper resource cleanup in Java
Maintain Java 11 compatibility when possible for OpenSearch 2.x
Document Calcite-specific workarounds in code

Files:

• legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java

---

⚙️ CodeRabbit configuration file

**/*.java: - Flag methods >50 lines as potentially too complex - suggest refactoring

• Flag classes >500 lines as needing organization review
• Check for dead code, unused imports, and unused variables
• Identify code reuse opportunities across similar implementations
• Assess holistic maintainability - is code easy to understand and modify?
• Flag code that appears AI-generated without sufficient human review
• Verify Java naming conventions (PascalCase for classes, camelCase for methods/variables)
• Check for proper JavaDoc on public classes and methods
• Flag redundant comments that restate obvious code
• Ensure proper error handling with specific exception types
• Check for Optional usage instead of null returns
• Validate proper use of try-with-resources for resource management

Files:

• legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)

• GitHub Check: enforce-label
• GitHub Check: build-linux (21, unit)
• GitHub Check: bwc-tests-full-restart (25)
• GitHub Check: build-linux (21, doc)
• GitHub Check: build-linux (21, integration)
• GitHub Check: bwc-tests-rolling-upgrade (21)
• GitHub Check: build-linux (25, unit)
• GitHub Check: build-linux (25, integration)
• GitHub Check: build-linux (25, doc)
• GitHub Check: bwc-tests-full-restart (21)
• GitHub Check: bwc-tests-rolling-upgrade (25)
• GitHub Check: security-it-linux (25)
• GitHub Check: security-it-linux (21)
• GitHub Check: build-windows-macos (macos-14, 25, doc)
• GitHub Check: build-windows-macos (macos-14, 25, integration)
• GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, unit)
• GitHub Check: build-windows-macos (windows-latest, 25, -PbuildPlatform=windows, integration)
• GitHub Check: build-windows-macos (macos-14, 25, unit)
• GitHub Check: build-windows-macos (macos-14, 21, integration)
• GitHub Check: build-windows-macos (macos-14, 21, doc)
• GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, unit)
• GitHub Check: build-windows-macos (macos-14, 21, unit)
• GitHub Check: build-windows-macos (windows-latest, 21, -PbuildPlatform=windows, integration)
• GitHub Check: security-it-windows-macos (windows-latest, 21)
• GitHub Check: security-it-windows-macos (macos-14, 21)
• GitHub Check: security-it-windows-macos (macos-14, 25)
• GitHub Check: security-it-windows-macos (windows-latest, 25)
• GitHub Check: test-sql-cli-integration (21)
• GitHub Check: CodeQL-Scan (java)

🔇 Additional comments (1)

legacy/src/main/java/org/opensearch/sql/legacy/executor/format/SelectResultSet.java (1)

180-180: The mapping retrieval change correctly handles index aliases.

The change from mappings.get(indexName) to mappings.values().iterator().next() is necessary because GetFieldMappingsRequest returns results keyed by the actual index name instead of the alias used in the query. This is the correct approach for this legacy executor code to support alias-based queries.

The size check (mappings.size() != 1) explicitly prevents multi-index scenarios by throwing an exception, so the concern about multi-index queries breaking is not applicable here. The mapping key is not needed for subsequent operations—only the field metadata values are used in populateColumns().

Consider adding a code comment documenting that positional access is necessary due to alias resolution behavior in GetFieldMappingsRequest.