Fix/workflow validation ~10 delegation monitor limit#2145
Open
thecodingshrimp wants to merge 1 commit into
Open
Fix/workflow validation ~10 delegation monitor limit#2145thecodingshrimp wants to merge 1 commit into
thecodingshrimp wants to merge 1 commit into
Conversation
The validateMonitorAccess() function in TransportIndexWorkflowAction was not setting an explicit size parameter on the search query, causing OpenSearch to default to returning only 10 results. When a Security Analytics detector referenced more than 10 rules (generating >10 delegate monitors), the validation would incorrectly report that the additional monitor IDs were invalid. This fix adds .size(monitorIds.size) to the SearchSourceBuilder to ensure all delegate monitor IDs are returned and validated correctly. Fixes issue where detector creation fails with '400 Bad Request: <monitor_ids> are not valid monitor ids' when using >10 rules. Signed-off-by: thecodingshrimp <leonard.stutzer@sap.com>
dc6a6bc to
0b42d12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in workflow validation where creating a Security Analytics detector with more than 10 rules fails with an "invalid monitor ids" error (#2144).
Root Cause:
The
validateMonitorAccess()function inTransportIndexWorkflowAction.ktwas not setting an explicit size parameter on the search query. This caused OpenSearch to default to returning only the first 10 results. When a Security Analytics detector referenced more than 10 rules (generating more than 10 delegate monitors), the validation would incorrectly report that the additional monitor IDs were invalid.The Fix:
Added
.size(monitorIds.size)to theSearchSourceBuilderon line 716 to ensure all delegate monitor IDs are returned and validated correctly.Code Change:
Impact:
Related Issues
#2144
Example Error (Before Fix):
Check List
WorkflowRestApiIT.ktvalidates workflow creation and monitor validation scenarios.--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.