Fix JavaxWebXmlToJakartaWebXml regex to match multiline schemaLocation #971
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex pattern for matching xsi:schemaLocation attributes was failing when the attribute value contained line breaks, as `.` doesn't match newlines by default. Added `(?s)` flag to enable dotall mode. Fixes #970 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the regex pattern in
JavaxWebXmlToJakartaWebXmlrecipe to handlexsi:schemaLocationattributes with embedded line breaksAdded
(?s)flag (dotall mode) to the regex.*xml/ns/javaee.*so that.matches newline charactersAdded test case to verify the fix works with multi-line schemaLocation values
Fixes JavaxWebXmlToJakartaWebXml does not properly update if schemaLocation contains a linebreak #970
Test plan
migrateMultilineSchemaLocationtest case that verifies the recipe handles attributes with line breaks🤖 Generated with Claude Code