Use var for variables initialized with type casts
#965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBoegers
approved these changes
Jan 13, 2026
Contributor
MBoegers
left a comment
MBoegers
left a comment
There was a problem hiding this comment.
LGTM, great to see another edge case closed.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a new recipe with very limited scope in applying
varonly where initialized by a type cast within methods.What's your motivation?
This seemed like a simple and safe, non-controversial usage of
varthat we can then adopt in our tests, which frequently unpack and cast.Anything in particular you'd like reviewers to focus on?
Any edge cases where this might be unsafe?
Have you considered any alternatives or workarounds?
Could have also tackled static initializer blocks, but that seemed rare to me to have casts there.