Skip to content

fix IndexOutOfBoundsException that occurs in UseNoArgsConstructor when visiting record compact constructor method #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 4 commits into from
Jan 9, 2026
Merged

fix IndexOutOfBoundsException that occurs in UseNoArgsConstructor when visiting record compact constructor method #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93c2a57
fix IndexOutOfBoundsException
zakaria-shahen Jan 9, 2026
dc3c785
fix
zakaria-shahen Jan 9, 2026
73c6d28
fix
zakaria-shahen Jan 9, 2026
a5f0a6c
Merge branch 'main' into issues/index-out-of-bounds-exception-noargs
timtebeek Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.openrewrite.java.JavaIsoVisitor;
import org.openrewrite.java.JavaParser;
import org.openrewrite.java.JavaTemplate;
import org.openrewrite.java.marker.CompactConstructor;
import org.openrewrite.java.tree.J;
import org.openrewrite.java.tree.TypeUtils;

Expand All @@ -51,8 +52,9 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
return new JavaIsoVisitor<ExecutionContext>() {
@Override
public J.@Nullable MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
if (method.isConstructor() &&
method.getParameters().get(0) instanceof J.Empty &&
if (method.isConstructor() &&
!method.getMarkers().findFirst(CompactConstructor.class).isPresent() &&
method.getParameters().get(0) instanceof J.Empty &&
method.getBody() != null && method.getBody().getStatements().isEmpty()) {
J.ClassDeclaration enclosing = getCursor().firstEnclosing(J.ClassDeclaration.class);
AccessLevel accessLevel = LombokUtils.getAccessLevel(method);
Expand Down
18 changes: 18 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/lombok/UseNoArgsConstructorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,24 @@ public A() {
);
}

@Test
void keepCompactConstructor() {
rewriteRun(
//language=java
java(
"""
public record Foo(String id) {
public Foo {
if (id == null || id.isBlank()) {
throw new IllegalArgumentException("ID cannot be null or blank");
}
}
}
"""
)
);
}

@Test
void replaceEmptyProtectedConstructor() {
rewriteRun(
Expand Down