Skip to content

Expose df in Rubin pooling + support varying d.f. #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
munoztd0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose df in Rubin pooling + support varying d.f. #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# rbmi (development version)

## New Features
- Expose `df` in the pooled output of `pool_internal_rubin()`
- Add the `median(dfs)` fallback for varying d.f. (MMRM case)

## Bug Fixes
* Added en-GB spell-check and a corresponding test to the package
* Fixed numerous spelling errors and standardised nomenclature for missing not
Expand Down
8 changes: 2 additions & 6 deletions R/pool.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,7 @@ pool_internal.rubin <- function(results, conf.level, alternative, type, D) {
dfs <- results$df
alpha <- 1 - conf.level

v_com <- unique(dfs)

assert_that(
length(v_com) == 1,
msg = "Degrees of freedom should be consistent across all samples"
)
v_com <- if (length(unique(dfs)) == 1) unique(dfs) else median(dfs)

res_rubin <- rubin_rules(
ests = ests,
Expand All @@ -302,6 +297,7 @@ pool_internal.rubin <- function(results, conf.level, alternative, type, D) {
pfun = pt,
df = res_rubin$df
)
ret$df <- res_rubin$df

return(ret)
}
Expand Down