Fix for wrong estimates with relabelled factors#111
Merged
Conversation
clarkliming
approved these changes
Mar 30, 2026
Collaborator
clarkliming
left a comment
clarkliming
left a comment
There was a problem hiding this comment.
thank you so much for fixing! @gravesti
Contributor
Author
|
Thanks for merging this. Would it be possible to get this version released
on CRAN?
…On Mon, 30 Mar 2026 at 05:24, Liming ***@***.***> wrote:
Merged #111 <#111> into main.
—
Reply to this email directly, view it on GitHub
<#111?email_source=notifications&email_token=AT6IXODB6QWTAQYRFDUFTJ34THSGNA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENBQGE4TGOBZGQ4DJJTSMVQXG33OU5WWK3TUNFXW5JLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#event-24019389484>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6IXOGAOPJGDY4GSKWAO3L4THSGNAVCNFSM6AAAAACW6VMHNSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUGAYTSMZYHE2DQNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source of the bug is surprising to me, because I thought that
model.matrixwould properly apply thexlevelsfromfitto the new counterfactual datadf, but it doesn't seem to...See #69