Skip to content

transport: Fix NACK received on fragmented packet. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iabdalkader merged 1 commit into from
Mar 28, 2026
Merged

transport: Fix NACK received on fragmented packet. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/openmv/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,6 @@ def recv_packet(self, poll_events=False):
start_time = time.time()
continue # Continue collecting fragments

# Either last fragment or non-fragmented packet
if fragments:
# This is the last fragment - combine all
fragments.extend(packet['payload'])
packet['payload'] = bytes(fragments)
packet['length'] = len(fragments)

# Handle NAK flags
if packet['flags'] & Flags.NAK:
# Raise specific exception for all NAK statuses except BUSY
Expand All @@ -248,6 +241,13 @@ def recv_packet(self, poll_events=False):
raise OMVException(f"Command failed with status: {Status(status).name}")
return False

# Either last fragment or non-fragmented packet
if fragments:
# This is the last fragment - combine all
fragments.extend(packet['payload'])
packet['payload'] = bytes(fragments)
packet['length'] = len(fragments)

# Return payload or True for ACK
return True if not packet['length'] else bytes(packet['payload'])

Expand Down
Loading