f-string guidelines using Flynt #1406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor readme changes for better readability
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1406 +/- ##
===========================================
+ Coverage 84.05% 84.09% +0.04%
===========================================
Files 38 38
Lines 5230 5231 +1
===========================================
+ Hits 4396 4399 +3
+ Misses 834 832 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PGijsbers
requested changes
Jun 17, 2025
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Part of the old text also became obsolete.
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
PGijsbers
reviewed
Jun 17, 2025
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
PGijsbers
reviewed
Jun 17, 2025
PGijsbers
reviewed
Jun 18, 2025
tests/test_extensions/test_sklearn_extension/test_sklearn_extension.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #1295
What does this PR implement/fix? Explain your changes.
As Eddie and Pieter mentioned in #1295, this runs Flynt (a compliancy checker for f-strings) on the codebase, and adds a guideline for future contributors to ensure compliance.
How should this PR be tested?
This does not add any new functionality. Just converts non f-strings to f-strings, so hopefully all the current tests should just work.
Any other comments?