Skip to content

Conversation

@PGijsbers
Copy link
Collaborator

Reference Issue

None, recent issues with proxy.

What does this PR implement/fix? Explain your changes.

Sets the default url to use the api subdomain, which avoids a layer of indirection and subsequently should be stable.
It also fixes an issue with the CLI tool so that it's possible again to set variables through it.

How should this PR be tested?

Affects all endpoints. Not really that suitable for manual testing.

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.35%. Comparing base (00d1766) to head (609f1f2).

Files with missing lines Patch % Lines
openml/config.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1393      +/-   ##
===========================================
+ Coverage    84.33%   84.35%   +0.01%     
===========================================
  Files           38       38              
  Lines         5325     5325              
===========================================
+ Hits          4491     4492       +1     
+ Misses         834      833       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@LennartPurucker LennartPurucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me and the code works with "https://api.openml.org/api/v1/xml" for me bug free.

I cannot see yet how it affects the CLI

Comment on lines +405 to +407
value = globals()[f] if f == field else config.get(f) # type: ignore
if value is not None:
fh.write(f"{f} = {value}\n")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not being clear about the CLI fix. That's this bit of code.. it's used only by the CLI (I think). I understand that's not particularly clear since the other edit is in the cli.py file which you might reasonably expect to also have the fix that was mentioned.

Basically, if f!=field then it would write the name of the variable to itself (e.g., apikey = apikey), instead of fetching the corresponding value from the configuration and re-writing that.

@PGijsbers PGijsbers merged commit a8ecf1e into develop Jun 16, 2025
10 of 13 checks passed
@PGijsbers PGijsbers deleted the fix/update-api-url branch June 16, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants