-
-
Notifications
You must be signed in to change notification settings - Fork 211
DRAFT : function to allow adding arbitrary files to the run object #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SubhadityaMukherjee
wants to merge
3
commits into
openml:main
Choose a base branch
from
SubhadityaMukherjee:add_file_to_run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -707,3 +707,46 @@ def _to_dict(self) -> dict[str, dict]: # noqa: PLR0912, C901 | |
| current, | ||
| ) | ||
| return description | ||
|
|
||
| def _check_file_size(self, file: Any, max_file_size_mb: int = 100) -> bool: | ||
| """Check file size for file-like objects""" | ||
| file_size = 0 | ||
| if isinstance(file, (bytes, bytearray)): # If file is a binary data | ||
| file_size = len(file) | ||
| elif hasattr(file, "read") and hasattr(file, "seek"): # File-like object | ||
| current_pos = file.tell() # Save the current position | ||
| file.seek(0, 2) # Move to the end of the file | ||
| file_size = file.tell() | ||
| file.seek(current_pos) # Restore the original position | ||
| else: | ||
| raise TypeError("Unsupported file type. Provide binary data or a file-like object.") | ||
|
|
||
| if file_size > max_file_size_mb * 1024 * 1024: # MB in bytes | ||
| return False | ||
| return True | ||
|
|
||
| def add_file_to_run(self, file: Any, name: str, max_file_size_mb: int = 100) -> None: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with Lennart we should just have proper support if we add this, e.g., simply keep a |
||
| """ | ||
| Add a file to the run object. This file will be uploaded to the server | ||
| when the run is published with a name specified by the user. | ||
| Ensures that the file size is less than 100MB. | ||
| """ | ||
| # Check if path was provided and return an error | ||
| if isinstance(file, (str, Path)): | ||
| raise TypeError("Provide the file content instead of the file path.") | ||
|
|
||
| # Check if the file size exceeds the limit | ||
| if not self._check_file_size(file, max_file_size_mb): | ||
| raise ValueError(f"File size exceeds {max_file_size_mb}MB. File: {name}") | ||
|
|
||
| # Save reference to the original method | ||
| self._old_get_file_elements = self._get_file_elements | ||
|
|
||
| # Add the new file to the file elements dictionary with the specified name | ||
| def modified_get_file_elements(): | ||
| elements = self._old_get_file_elements() | ||
| elements[name] = (name, file) | ||
| return elements | ||
|
|
||
| # Override the original data | ||
| self._get_file_elements = modified_get_file_elements | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at https://docs.python.org/3/library/pathlib.html#pathlib.Path.stat :)