adding RegularMesh.get_indices_at_coords to match CylindricalMesh#3824
adding RegularMesh.get_indices_at_coords to match CylindricalMesh#3824shimwell wants to merge 5 commits intoopenmc-dev:developfrom
Conversation
|
I suggest making |
|
You also should decide on a way to signal that a point is outside the mesh. |
|
Thanks for this idea @GuySten I have made the abstract method. Would it be ok if I leave the spherical mesh and rectilinear mesh implementation of get_indices_at_coords to another PR, I added not yet implemented errors for those options if that helps in the short term. Also the point outside of the mesh question, not sure what is best to do there. Cylindrical mesh doesn't do anything special in that case so this PR is following that precedence. Would a warning message that prints when a user puts in a point outside the mesh be the best option for this? |
|
I think it is fine. |
Description
To match the
CylindricalMeshwhich has this function class I am keen to add thisget_indices_at_coordsfunction to theRegularMeshclass.Fixes # (issue)
Checklist