Pulse height does not score over whole geometry when no cell filter present.#3821
Pulse height does not score over whole geometry when no cell filter present.#3821GuySten wants to merge 1 commit intoopenmc-dev:developfrom
Conversation
|
Thanks for your work again. I am not sure if we need this. Why would you want to know the pulse-height over the entire geometry when no CellFilter is provided? |
|
I discovered this unexpected behavior while trying to test a simple example containing one cell. This can be useful for example when you have a model of one cell that is the detector vacuum boundary conditions and a fixed source. Now you have to specifiy a cell filter with that one cell as a workaround. |
|
Each filter must have the default "neutral" form |
Description
Currently when no CellFilter is specified, pulse height tally results are always 0.
This PR fix that and now when no cell filter is specified, all the geometry is scored to.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)