making use of endf.get_evaluations#3819
Open
shimwell wants to merge 2 commits intoopenmc-dev:developfrom
Open
Conversation
Contributor
|
The endf package use Material object which is not identical to the Evaluation object that openmc use (at least the name is different). |
Member
Author
|
What do you think @paulromano Here is a link to the get_material function in endf which is the same content but different name to the get_evaluations over here in openmc world. We could adopt the endf-python standard and rename any use of get_evaluations to get_materials across the openmc codebase as part of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
making use of endf.get_evaluations from the endf-python package made by paul. this continue the theme of saving a few lines and reducing duplication. endf-python is already a dependency.
let me know if these PR are too small just for future reference.
Fixes # (issue)
Checklist
I have performed a self-review of my own code
I have followed the style guidelines for Python source files (if applicable)