Skip to content

Comments

making use of endf.get_evaluations#3819

Open
shimwell wants to merge 2 commits intoopenmc-dev:developfrom
shimwell:making-more-use-of-endf-package-8
Open

making use of endf.get_evaluations#3819
shimwell wants to merge 2 commits intoopenmc-dev:developfrom
shimwell:making-more-use-of-endf-package-8

Conversation

@shimwell
Copy link
Member

@shimwell shimwell commented Feb 18, 2026

Description

making use of endf.get_evaluations from the endf-python package made by paul. this continue the theme of saving a few lines and reducing duplication. endf-python is already a dependency.

let me know if these PR are too small just for future reference.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code

  • I have followed the style guidelines for Python source files (if applicable)

@shimwell shimwell requested a review from paulromano as a code owner February 18, 2026 17:13
@GuySten
Copy link
Contributor

GuySten commented Feb 19, 2026

The endf package use Material object which is not identical to the Evaluation object that openmc use (at least the name is different).
I think this change will be ok only if we move the Evaluation object to the endf package.

@shimwell
Copy link
Member Author

What do you think @paulromano

Here is a link to the get_material function in endf which is the same content but different name to the get_evaluations over here in openmc world.

https://github.com/paulromano/endf-python/blob/7bf0f8c1ced3c42bee8e0f6f2ce9182fa9b1041a/src/endf/material.py#L265-L289

We could adopt the endf-python standard and rename any use of get_evaluations to get_materials across the openmc codebase as part of this PR?

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimwell!

@paulromano paulromano enabled auto-merge (squash) February 25, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants