chore(closes OPEN-8832): optionally upload data from external URLs to…#591
Merged
gustavocidornelas merged 1 commit intomainfrom Feb 25, 2026
Merged
chore(closes OPEN-8832): optionally upload data from external URLs to…#591gustavocidornelas merged 1 commit intomainfrom
gustavocidornelas merged 1 commit intomainfrom
Conversation
matheusportela
approved these changes
Feb 25, 2026
matheusportela
left a comment
matheusportela
left a comment
There was a problem hiding this comment.
LGTM. At some point, we should refactor the upload_attachment method because it is massive and has too many responsibilities. That's not a blocker, though, and shouldn't delay this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… our storage
Pull Request
Summary
Adds a new configuration param (bool):
url_upload_enabled. When set toTrue, attachments that are referencing external URLs are downloaded and then re-uploaded to the Openlayer backend.This is an opt-in feature that is important to assert attachments are persistent on Openlayer even when external URLs remove them.
Changes
Context
OPEN-8832: Optionally upload data from external URLs to our storage
Testing