Skip to content

8374712: AOTMappedHeapWriter::relocate_field_in_buffer should use CompressedOops::narrow_oop_cast#582

Open
GoeLin wants to merge 1 commit into
openjdk:pr/581from
GoeLin:goetz_backport_8374712
Open

8374712: AOTMappedHeapWriter::relocate_field_in_buffer should use CompressedOops::narrow_oop_cast#582
GoeLin wants to merge 1 commit into
openjdk:pr/581from
GoeLin:goetz_backport_8374712

Conversation

@GoeLin
Copy link
Copy Markdown
Member

@GoeLin GoeLin commented May 27, 2026

follow-up to JDK-8363986

clean except for file name and indentation.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8374712 needs maintainer approval

Integration blocker

 ⚠️ Dependency #581 must be integrated first

Issue

  • JDK-8374712: AOTMappedHeapWriter::relocate_field_in_buffer should use CompressedOops::narrow_oop_cast (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/582/head:pull/582
$ git checkout pull/582

Update a local copy of the PR:
$ git checkout pull/582
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/582/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 582

View PR using the GUI difftool:
$ git pr show -t 582

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/582.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 27, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 27, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@GoeLin GoeLin changed the base branch from master to pr/581 May 27, 2026 07:41
@GoeLin GoeLin changed the title Goetz backport 8374712 backport 70669d0585c708e04befe0f9ba945f6154f9afec May 27, 2026
@openjdk openjdk Bot changed the title backport 70669d0585c708e04befe0f9ba945f6154f9afec 8374712: AOTMappedHeapWriter::relocate_field_in_buffer should use CompressedOops::narrow_oop_cast May 27, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 27, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 27, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 27, 2026

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8374712 branch from d42f6d8 to ef725ab Compare May 27, 2026 08:05
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 27, 2026

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant