Skip to content

8362884: [GCC static analyzer] unix NetworkInterface.c addif leak on early returns#579

Open
fthevenet wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-fthevenet-a2da75a6-master
Open

8362884: [GCC static analyzer] unix NetworkInterface.c addif leak on early returns#579
fthevenet wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-fthevenet-a2da75a6-master

Conversation

@fthevenet
Copy link
Copy Markdown
Member

@fthevenet fthevenet commented May 26, 2026

Hi all,

This pull request contains a backport of commit a2da75a6 from the openjdk/jdk repository.

The commit being backported was authored by Volkan Yazici on 29 Aug 2025 and was reviewed by Daniel Fuchs and Matthias Baesken.

Thanks!



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8362884 needs maintainer approval

Issue

  • JDK-8362884: [GCC static analyzer] unix NetworkInterface.c addif leak on early returns (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/579/head:pull/579
$ git checkout pull/579

Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 579

View PR using the GUI difftool:
$ git pr show -t 579

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/579.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 26, 2026

👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport a2da75a6b69f56be41741bffba2c6874a93dfa40 8362884: [GCC static analyzer] unix NetworkInterface.c addif leak on early returns May 26, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 26, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

⚠️ @fthevenet This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 26, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 26, 2026

Webrevs

@fthevenet
Copy link
Copy Markdown
Member Author

/approval request I'd like to backport this to JDK 25.

Motivation: This fixes a small memory leak in the event of an early returns where memory allocated by the CHECKED_MALLOC3 may never be freed.
Besides this, another motivation is that this allow for a functionally clean backport of JDK-8378180

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 26, 2026

@fthevenet
8362884: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant