8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII#269
8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII#269vish-chan wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into |
|
@vish-chan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 43 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for Clean backport of 8365570 - C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII This is a low risk fix as it fixes assert failure in superword truncation with CastII. Since casts specifically change the type of a node, they should not be truncated during vectorization to maintain type safety. |
|
@vish-chan |
|
/integrate |
|
@vish-chan |
|
/sponsor |
|
Going to push as commit be61f28.
Your commit was automatically rebased without conflicts. |
|
@phohensee @vish-chan Pushed as commit be61f28. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of 8365570 - C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII
Fixes assert failure in superword truncation with CastII. Since casts specifically change the type of a node, they should not be truncated during vectorization to maintain type safety.
Additional Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/269/head:pull/269$ git checkout pull/269Update a local copy of the PR:
$ git checkout pull/269$ git pull https://git.openjdk.org/jdk25u-dev.git pull/269/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 269View PR using the GUI difftool:
$ git pr show -t 269Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/269.diff
Using Webrev
Link to Webrev Comment