Skip to content

8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII#269

Closed
vish-chan wants to merge 1 commit intoopenjdk:masterfrom
vish-chan:8365570
Closed

8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII#269
vish-chan wants to merge 1 commit intoopenjdk:masterfrom
vish-chan:8365570

Conversation

@vish-chan
Copy link
Copy Markdown
Contributor

@vish-chan vish-chan commented Feb 14, 2026

Clean backport of 8365570 - C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII

  • Fixes assert failure in superword truncation with CastII. Since casts specifically change the type of a node, they should not be truncated during vectorization to maintain type safety.

  • Additional Testing:

  • New regression test fails without the fix, passes with it.
  • Linux x86_64 server fastebug compiler tests.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8365570 needs maintainer approval

Issue

  • JDK-8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/269/head:pull/269
$ git checkout pull/269

Update a local copy of the PR:
$ git checkout pull/269
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 269

View PR using the GUI difftool:
$ git pr show -t 269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/269.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Feb 14, 2026

👋 Welcome back vish-chan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@vish-chan vish-chan marked this pull request as ready for review February 14, 2026 08:00
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 14, 2026

@vish-chan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 775f48de6129092d05650fec17dad171944e6d89 8365570: C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII Feb 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 14, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 14, 2026

⚠️ @vish-chan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Feb 14, 2026

Webrevs

@vish-chan
Copy link
Copy Markdown
Contributor Author

/approval request for Clean backport of 8365570 - C2 fails assert(false) failed: Unexpected node in SuperWord truncation: CastII

This is a low risk fix as it fixes assert failure in superword truncation with CastII. Since casts specifically change the type of a node, they should not be truncated during vectorization to maintain type safety.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 14, 2026

@vish-chan
8365570: The approval request has been created successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 14, 2026
@vish-chan
Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Feb 24, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 24, 2026

@vish-chan
Your change (at version 76da872) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 26, 2026

Going to push as commit be61f28.
Since your change was applied there have been 47 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Feb 26, 2026
@openjdk openjdk Bot closed this Feb 26, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 26, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 26, 2026

@phohensee @vish-chan Pushed as commit be61f28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants