Skip to content

8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java#258

Closed
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8363949-V25
Closed

8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java#258
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8363949-V25

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Feb 11, 2026

Backporting JDK-8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java.

This PR fixes the MonitorWithDeadObjectTest.java jtreg header by moving @test tag to first position, resolving "Not a test or directory containing tests" error caused by @requires appearing before @test.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/runtime/Monitor/MonitorWithDeadObjectTest.java

Results attached:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log


Progress

  • JDK-8363949 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/258/head:pull/258
$ git checkout pull/258

Update a local copy of the PR:
$ git checkout pull/258
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 258

View PR using the GUI difftool:
$ git pr show -t 258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/258.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Feb 11, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 11, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport c4fbfa21030c9a0e8a3e0eed1b0a0988eba08ddb 8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java Feb 11, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 11, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 11, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review February 11, 2026 20:20
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 11, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 11, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Feb 11, 2026

Webrevs

@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Feb 12, 2026

/approval request for backport of JDK-8363949: Incorrect jtreg header in MonitorWithDeadObjectTest.java.

This is a test fix.

For parity with Oracle JDK.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 12, 2026

@rm-gh-8
8363949: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Feb 12, 2026
@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 8, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Mar 10, 2026

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 10, 2026

@rm-gh-8
Your change (at version 75266aa) is now ready to be sponsored by a Committer.

@simonis
Copy link
Copy Markdown
Member

simonis commented Mar 10, 2026

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 10, 2026

Going to push as commit cc0debb.
Since your change was applied there have been 99 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 10, 2026
@openjdk openjdk Bot closed this Mar 10, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 10, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 10, 2026

@simonis @rm-gh-8 Pushed as commit cc0debb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants