8367772: Refactor createUI in PassFailJFrame

[rm-gh-8]

Backporting JDK-8367772: Refactor createUI in PassFailJFrame.

This PR refactors PassFailJFrame UI creation to use Builder pattern internally, eliminating parameter proliferation and code duplication.

For parity with Oracle JDK.

Ran a manual test that uses the PassFailJFrame on macos-aarch64:

~/github/jtreg/build/images/jtreg/bin/jtreg -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/java/awt/Dialog/ModalDialogTest/ModalDialogTest.java

ScreenShots:

Results:

summary.txt

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8367772 needs maintainer approval

Issue

• JDK-8367772: Refactor createUI in PassFailJFrame (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/250/head:pull/250
$ git checkout pull/250

Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 250

View PR using the GUI difftool:
$ git pr show -t 250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/250.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367772: Refactor createUI in PassFailJFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 0e11a1a: 8368677: acvp test should throw SkippedException when no ACVP-Server available
• 2feddce: 8375598: VM crashes with "assert((labs(val) & 0xFFFFFFFF00000000) == 0 || dest == (address)-1) failed: must be 32bit offset or -1" when using too high value for NonNMethodCodeHeapSize
• db62fdd: 8373021: aarch64: MacroAssembler::arrays_equals reads out of bounds
• ... and 20 more: https://git.openjdk.org/jdk25u-dev/compare/40ec273de548b47fc08d02bbe7c1cb3b48ebad17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[rm-gh-8]

/approval request for backport of JDK-8367772: Refactor createUI in PassFailJFrame.

This is a test fix.

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8367772: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (7e55699a)

[rm-gh-8]

/integrate

[openjdk]

@rm-gh-8
Your change (at version 7e55699) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit ea96f83.
Since your change was applied there have been 28 commits pushed to the master branch:

• a126116: 8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently
• a89c485: 8299304: Test "java/awt/print/PrinterJob/PageDialogTest.java" fails on macOS 13 x64 because the Page Dialog blocks the Toolkit
• 9d6884a: 8342401: [TESTBUG] javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java test fails in ubuntu 22.04 on SBR Hosts
• ... and 25 more: https://git.openjdk.org/jdk25u-dev/compare/40ec273de548b47fc08d02bbe7c1cb3b48ebad17...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rm-gh-8 Pushed as commit ea96f83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.