-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374632: Broken list layout in the man page of jlink #29083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8374632: Broken list layout in the man page of jlink #29083
Conversation
|
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
|
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
irisclark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed changes identical to those pushed to main line.
|
Thank you Iris for the review. |
|
/integrate |
|
Going to push as commit d0a3ba9. |
Can I please get a review of this (clean) backport of the doc-only fix to jlink's man page? The original fix was done in JDK mainline by Ana here #29069 and addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374632.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29083/head:pull/29083$ git checkout pull/29083Update a local copy of the PR:
$ git checkout pull/29083$ git pull https://git.openjdk.org/jdk.git pull/29083/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29083View PR using the GUI difftool:
$ git pr show -t 29083Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29083.diff
Using Webrev
Link to Webrev Comment