Skip to content

Conversation

@jaikiran
Copy link
Member

@jaikiran jaikiran commented Jan 7, 2026

Can I please get a review of this (clean) backport of the doc-only fix to jlink's man page? The original fix was done in JDK mainline by Ana here #29069 and addresses the issue noted in https://bugs.openjdk.org/browse/JDK-8374632.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374632: Broken list layout in the man page of jlink (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29083/head:pull/29083
$ git checkout pull/29083

Update a local copy of the PR:
$ git checkout pull/29083
$ git pull https://git.openjdk.org/jdk.git pull/29083/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29083

View PR using the GUI difftool:
$ git pr show -t 29083

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29083.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2026

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374632: Broken list layout in the man page of jlink

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk26 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a01283a5a57723673b1fd3c93434678fdae4102c 8374632: Broken list layout in the man page of jlink Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@jaikiran The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 7, 2026

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed changes identical to those pushed to main line.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2026
@jaikiran
Copy link
Member Author

jaikiran commented Jan 8, 2026

Thank you Iris for the review.

@jaikiran
Copy link
Member Author

jaikiran commented Jan 8, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2026

Going to push as commit d0a3ba9.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2026
@openjdk openjdk bot closed this Jan 8, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2026
@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@jaikiran Pushed as commit d0a3ba9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants