-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext" #29064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jdk26
Are you sure you want to change the base?
8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext" #29064
Conversation
|
👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@Shivangi-aa The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
@dfuch Can you please review this? |
|
Hello Shivangi, I will talk to Volkan tomorrow to decide if we should backport this or do it at a later date. |
|
I'm keen on backporting JDK-8372661 Edit: JDK-8372661 implements the null-safe static factory methods in a backward-compatible way, and its sub-tasks migrates tests to use the new factory methods. Hence, backporting sub-tasks are not necessary. |
8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext"
Straight Backport
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29064/head:pull/29064$ git checkout pull/29064Update a local copy of the PR:
$ git checkout pull/29064$ git pull https://git.openjdk.org/jdk.git pull/29064/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29064View PR using the GUI difftool:
$ git pr show -t 29064Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29064.diff
Using Webrev
Link to Webrev Comment