Skip to content

Conversation

@Shivangi-aa
Copy link

@Shivangi-aa Shivangi-aa commented Jan 6, 2026

8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext"
Straight Backport


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext" (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29064/head:pull/29064
$ git checkout pull/29064

Update a local copy of the PR:
$ git checkout pull/29064
$ git pull https://git.openjdk.org/jdk.git pull/29064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29064

View PR using the GUI difftool:
$ git pr show -t 29064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29064.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2026

👋 Welcome back sshivang! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 629e4ac6f45c87898f6a014f28a443c800413869 8372661: Add a null-safe static factory method to "jdk.test.lib.net.SimpleSSLContext" Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required security security-dev@openjdk.org net net-dev@openjdk.org labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@Shivangi-aa The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2026

Webrevs

@Shivangi-aa
Copy link
Author

@dfuch Can you please review this?

@jaikiran
Copy link
Member

jaikiran commented Jan 6, 2026

Hello Shivangi, I will talk to Volkan tomorrow to decide if we should backport this or do it at a later date.

@vy
Copy link
Contributor

vy commented Jan 7, 2026

I'm keen on backporting JDK-8372661 and all its sub-tasks (mind that their merge order matters!), preferably ASAP. It is a matter of time we will need to backport a change set touching tests that use SimpleSSLContext, and the author will need to deal with the merge conflict. Put another way, I am not able to see a reason to postpone this operation. That said, porting process can be complicated, and @dfuch has extensive experience on the subject. I will defer the "When shall we backport?" question to him.

Edit: JDK-8372661 implements the null-safe static factory methods in a backward-compatible way, and its sub-tasks migrates tests to use the new factory methods. Hence, backporting sub-tasks are not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required net net-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants