8385573: [CRaC] Fix use-after-free in engine options parsing

[TimPushkin]

Fixes the bug by using a single buffer for concatenated engine options.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8385573: [CRaC] Fix use-after-free in engine options parsing (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/320/head:pull/320
$ git checkout pull/320

Update a local copy of the PR:
$ git checkout pull/320
$ git pull https://git.openjdk.org/crac.git pull/320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 320

View PR using the GUI difftool:
$ git pr show -t 320

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/320.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385573: [CRaC] Fix use-after-free in engine options parsing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (36d15169)
• 00: Full (e8235568)

[TimPushkin]

The test failures are unrelated. I reported the two jdk/crac ones internally, and regarding Windows it looks like my repo just got "lucky" to use newer runner images earlier than the others'.