Conversation
Sakurann
requested review from
GarethCOliver,
awoie,
bc-pi,
c2bo,
hlozi,
jogu,
selfissued,
tlodderstedt and
tplooker
and removed request for
jogu
Sakurann
commented
Mar 12, 2026
|
|
||
| ### Response Encryption using HPKE with JWE | ||
|
|
||
| Response encryption MUST be performed as specified in [@!OIDF.OID4VP, section 8.3.1]. The JWE `alg` (algorithm) header parameter (see [@!RFC7516, section 4.1.1]) value `HPKE-0` (as defined in [@I-D.ietf-jose-hpke-encrypt]). The JWE `enc` (encryption algorithm) header parameter (see [@!RFC7516, section 4.1.2]) value `A128GCM` (as defined in [@!RFC7518, section 5.3]) MUST be supported by Verifiers and Wallets. |
Collaborator
Author
There was a problem hiding this comment.
need to omit enc.
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
GarethCOliver
approved these changes
Mar 26, 2026
Contributor
GarethCOliver
left a comment
GarethCOliver
left a comment
There was a problem hiding this comment.
lgtm with the suggested change.
javereec
reviewed
Apr 24, 2026
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com> Co-authored-by: Jan Vereecken <ciao@janvereecken.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #356
resolves #357
builds up on #361 (#361 needs to be merged first)