feat: form for interactive config file creation #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: René Kuhn <renekuhn@posteo.de>
Co-authored-by: René Kuhn <renekuhn@posteo.de>
Co-authored-by: René Kuhn <renekuhn@posteo.de>
The config file creation form will now place the config file in '/etc/docker/cinder.json' by default, as the systemd service expects the file to be at that location. The path can be changed by also supplying the '-config' flag and setting it to the wanted path. Co-authored-by: René Kuhn <renekuhn@posteo.de>
jgraichen
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the flag
-createConfigthat, when supplied, starts an interactive form which automatically creates a working configuration file for the plugin.The form works with Openstack application credentials as opposed to the account password, to prevent the password from being stored in plain text in the config file.
By default, the config file will be placed at
/etc/docker/cinder.json, as the systemd service expects the file to be at that location. The file can be written to a different path by also supplying the flag-config=<path>.