Make invoice MCP server and tests respect MCP_PORT env var#20
Open
turabe777 wants to merge 1 commit into
Open
Conversation
The invoice MCP server in challenge/mcp-servers/invoice and the test harnesses in challenge/mcp-server-invoice-test and challenge/llm-workflow-test all assumed a hard-coded port 8000 (uvicorn's default, and the default value of the --mcp-server-url CLI argument). This blocks multi-user / shared-host workshop setups where several participants need to run their own invoice server side by side on one machine. Changes: - server_http.py: read MCP_PORT env var (default 8000), pass to uvicorn.run. - mcp-server-invoice-test/main.py: --mcp-server-url default reads MCP_PORT. - llm-workflow-test/main.py: same as above. - Both READMEs: document the new env-var-aware default. Backward compatible: with MCP_PORT unset, behaviour is identical to before (server listens on 8000, tests connect to 8000). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: turabe777 <turabe@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invoice MCP server in challenge/mcp-servers/invoice and the test harnesses in challenge/mcp-server-invoice-test and challenge/llm-workflow-test all assumed a hard-coded port 8000 (uvicorn's default, and the default value of the --mcp-server-url CLI argument). This blocks multi-user / shared-host workshop setups where several participants need to run their own invoice server side by side on one machine.
Changes:
Backward compatible: with MCP_PORT unset, behaviour is identical to before (server listens on 8000, tests connect to 8000).