Upgrade slf4j and logback #541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerfriedrich
force-pushed
the
pr-logger
branch
from
8cccff1 to
fa16f64
Compare
kaikreuzer
reviewed
Dec 30, 2025
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-api</artifactId> | ||
| <version>${slf4j.version}</version> | ||
| <scope>provided</scope> |
Member
There was a problem hiding this comment.
The old dependency was with scope "provided" - is it intended that this has been removed with the upgrade?
Member
Author
There was a problem hiding this comment.
let me check if provided works here as well...
Member
Author
There was a problem hiding this comment.
I just tested running it on openhab-core, no problems.
mvn dependency:analyze does not complain as well.
So let's add the scope as before.
* Upgrade slf4j from 1.7.36 to 2.0.17 * Upgrade logback from 1.2.13 to 1.5.23 * Exclude slf4j-simple 1.7.x from pmd and checkstyle Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
force-pushed
the
pr-logger
branch
from
fa16f64 to
c46bc5e
Compare
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.