🐛(backend) hotfix on export csv, export orders and update length deeplinks#1341
Open
jonathanreveille wants to merge 3 commits into
Open
🐛(backend) hotfix on export csv, export orders and update length deeplinks#1341jonathanreveille wants to merge 3 commits into
jonathanreveille wants to merge 3 commits into
Conversation
jonathanreveille
force-pushed
the
hotfix/deeplink_length
branch
from
57d65bb to
f8fd118
Compare
jonathanreveille
changed the title
jonathanreveille
changed the title
jonathanreveille
changed the title
We forgot to add the migration file to update the url deep link length to 400 characters.
We want to simplify the extraction of the session code within the course run title. When it's for credential products we want to take care of two cases that is present in production. Also, we want to keep the session code empty when it's for certificate products.
To prevent errors in our sentry due to batch order that are completed but the orders are not yet claimed, we have decided to prevent to download the csv file at the API level.
jonathanreveille
force-pushed
the
hotfix/deeplink_length
branch
from
f8fd118 to
711cd1a
Compare
jonathanreveille
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Different fixes that occured in preproduction.
Proposal