Add map of Taiwan Strait

[RickD004]

Description:

Map of the Taiwan and the Chinese Mainland.

Team heavy map like Baikal and Hormuz. Terrain Source from OpenTopography, already credited

I also took the chance to standarize and sort alphabetically the map lists in main.go and MapPlaylist.ts.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star 1011

NOTE: If the map gets added, please give contributor to crunchybbbbb_59469 for this map on Discord. Every file was made by him, his PR just had weird bugs that didnt allow the PR to be review automatically

Original PR: #3853 by crunchybbb2-hash

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds the Taiwan Strait map: enum entry, map asset and resource manifest (dimensions and nations), map-generator registry update, server playlist reorder, and English localization entries.

Changes

Taiwan Strait Map Integration

Layer / File(s)	Summary
Data Type Definition src/core/game/Game.ts	GameMapType enum extended with TaiwanStrait = "Taiwan Strait".
Map Assets & Metadata map-generator/assets/maps/taiwanstrait/info.json, resources/maps/taiwanstrait/manifest.json	Adds Taiwan Strait asset and manifest with multi-scale dimensions and a nations array where each nation has coordinates, name, and flag. (manifest does not include mapInfoState or colorMappings.)
Generator Registry & Playlist map-generator/main.go, src/server/MapPlaylist.ts	Map generator registry reordered and expanded; tail IsTest: true entries preserved; server frequency playlist object reordered only.
Localization resources/lang/en.json	English localization keys added: map.taiwanstrait and map.bajacalifornia.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

New coasts sketched in data and name,
An enum set, a manifest framed,
Nations pinned with flags and line,
A registry tidy, locales align,
Taiwan Strait joins the map, refined. 🌊

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and directly summarizes the main changeset: adding a new Taiwan Strait map with supporting infrastructure across multiple files.
Description check	✅ Passed	The description is directly related to the changeset, explaining the map's purpose, terrain source, and supporting changes to map lists, with completed checklist items and contributor credits.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@map-generator/assets/maps/taiwanstrait/info.json`:
- Around line 1-182: Add an OpenTopography attribution entry to CREDITS.md for
the new map "TaiwanStrait" (the map described in the info.json with "name":
"TaiwanStrait") noting OpenTopography as the elevation/terrain data source and
include the relevant license or usage URL from OpenTopography; ensure the entry
follows existing CREDITS.md formatting for other maps (same fields/order) so the
new map's elevation source is properly credited.

In `@map-generator/main.go`:
- Around line 25-100: The added composite-literal entries like {Name: "aegean"},
{Name: "africa"}, ... are missing the leading tab used by the surrounding
slice/struct literal; add a single tab before each new {Name: "..."} line so
they align with the existing entries (match the indentation of the lines
above/below in the same composite literal) and then run gofmt to normalize
formatting before committing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 569dedde-5eeb-482d-8839-122ba74ee36e

📥 Commits

Reviewing files that changed from the base of the PR and between 4889cb8 and 3bafd8e.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/taiwanstrait/image.png is excluded by !**/*.png
• resources/maps/taiwanstrait/map.bin is excluded by !**/*.bin
• resources/maps/taiwanstrait/map16x.bin is excluded by !**/*.bin
• resources/maps/taiwanstrait/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/taiwanstrait/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/taiwanstrait/manifest.json
• resources/maps/taiwanstrait/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts