mls (v4.15)

[Aotumuri]

Description:

mls for v29
Version identifier within MLS: 4.14

This is the last mls for v29.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

French localization expanded with new UI keys and renames of existing entries. New comprehensive Indonesian language file added with 953 translation strings. Language metadata updated to register Indonesian. Minor Montreal translation adjustment in Turkish file.

Changes

Cohort / File(s)	Summary
French Localization Update resources/lang/fr.json	Expanded French translations: renamed main menu keys (create_lobby→create, join_lobby→join, single_player→solo), updated account modal (logged_in_as→connected_as), added 100+ new keys across game modals, gameplay elements, and UI states (keybind conflicts, accessibility tooltips, matchmaking, skins, map regions)
New Indonesian Localization resources/lang/id.json	Complete new Indonesian translation file with 953 translation strings covering all game sections: common UI, modals, gameplay mechanics, combat, chat, matchmaking, player stats, and game entities
Language Registry & Minor Updates resources/lang/metadata.json, resources/lang/tr.json	Added Indonesian language entry to metadata registry; added trailing newline to Montreal translation in Turkish file

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🌍✨ Words bloom across languages new,
French refined with names renamed true,
Indonesian joins the choir so bright,
Each string a bridge of cultural light! 🌐

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'mls (v4.15)' is vague and does not convey meaningful information about what changed; 'mls' is an unexplained acronym that fails to summarize the changeset clearly.	Replace with a descriptive title like 'Add Indonesian localization and update French translations for v29' to clarify the main changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description relates to the changeset by identifying it as an MLS (translation update) for v29 with version 4.14, and mentions testing and text processing requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

resources/lang/fr.json (1)

458-458: Fix small text issues in French strings.

One string shows a literal quote, one has a trailing space, and one word is misspelled.

🛠️ Proposed fixes

-    "performance_overlay_desc": "Activer/désactiver la surcouche de performances. Lorsqu'elle est activée, la surcouche de performances sera affichée. Appuyez sur Maj+D pendant le jeu pour l\"activer.",
+    "performance_overlay_desc": "Activer/désactiver la surcouche de performances. Lorsqu'elle est activée, la surcouche de performances sera affichée. Appuyez sur Maj+D pendant le jeu pour l'activer.",
@@
-    "menu_shortcuts": "Menu des raccourcis ",
+    "menu_shortcuts": "Menu des raccourcis",
@@
-    "building": "Batîment",
+    "building": "Bâtiment",

Also applies to: 488-488, 883-883

🤖 Fix all issues with AI agents

In `@resources/lang/id.json`:
- Line 313: The JSON value for the translation key "disabled_units" contains a
typo ("Nonaktfikan Units"); update the string to correct Indonesian (e.g., "Unit
Nonaktif" or "Nonaktifkan Unit" as appropriate for the UI) and then scan the
rest of resources/lang/id.json for similar spelling mistakes and fix the other
user-facing strings referenced in the review (the other Indonesian translation
keys around the listed sections) so all phrases are valid Indonesian and
consistent in terminology.
- Line 286: The translation entry for the key "surrounded" has a typo in its
value ("Surrourded"); update the value to the correct spelling "Surrounded" in
the "surrounded" entry in resources/lang/id.json so it matches the source
en.json.

In `@resources/lang/tr.json`:
- Line 273: The "montreal" translation value contains a trailing newline
("Montreal\n") which causes an unwanted line break; update the "montreal" key's
value to remove the "\n" so it reads "Montreal" (edit the JSON entry for the
"montreal" property).