Skip to content

Conversation

@evanpelle
Copy link
Collaborator

If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #(issue number)

Description:

Describe the PR.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

Walkthrough

Two configuration updates: DefaultConfig.ts simplifies trade and unit cost calculations by replacing complex sigmoid and geometric-mean formulas with direct power-law and piecewise mappings, while startup.sh removes an 18-hour timeout wrapper from supervisord execution under specific deployment conditions.

Changes

Cohort / File(s) Summary
Game Balance Configuration
src/core/configuration/DefaultConfig.ts
Trade ship gold calculation replaced with power-law formula (10000 + 150 × dist^1.1); trade ship spawn rate switched to deterministic piecewise mapping based on port count; MIRV unit cost fixed at 35,000,000; added toInt import to utilities
Deployment Configuration
startup.sh
Removed 18-hour timeout wrapper from supervisord execution in openfront.dev non-main subdomain branch

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

📊 Formulas fade to power's grace,
Sigmoid yields to cleaner space,
Timeout vanished with a sigh,
Constants reign—no reason why,
Simple wins the balance race! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is a template with placeholder text and uncompleted checklist items. It does not describe any actual changes or provide meaningful information about the PR. Replace the template with a genuine description explaining the trade meta updates, the rationale for changing calculation formulas, and any impact on gameplay or performance.
Title check ❓ Inconclusive Title 'use v22 trade meta' is vague and does not clearly convey what changes were made. It uses generic terminology without specific details about the modifications. Clarify the title to specifically describe the main changes, such as 'Update trade ship cost calculations and spawn rate logic' or similar concrete description of the changes made.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ryanbarlow97
Copy link
Contributor

+1 for v29

@VariableVince
Copy link
Contributor

+1 for v29

No because it didn't factor in Factories in v22? It's good that it makes it simpler again but would need a little more balancing first imo

@ryanbarlow97
Copy link
Contributor

+1 for v29

No because it didn't factor in Factories in v22? It's good that it makes it simpler again but would need a little more balancing first imo

well, factories are basically dead if we do this

@VariableVince
Copy link
Contributor

+1 for v29

No because it didn't factor in Factories in v22? It's good that it makes it simpler again but would need a little more balancing first imo

well, factories are basically dead if we do this

Factories were supposed to lessen the impact of being landlocked. Don't think we can simply remove them. Maybe they need a buff to compensate, while keeping it simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants