-
Notifications
You must be signed in to change notification settings - Fork 785
use v22 trade meta #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
use v22 trade meta #2935
Conversation
WalkthroughTwo configuration updates: DefaultConfig.ts simplifies trade and unit cost calculations by replacing complex sigmoid and geometric-mean formulas with direct power-law and piecewise mappings, while startup.sh removes an 18-hour timeout wrapper from supervisord execution under specific deployment conditions. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
+1 for v29 |
No because it didn't factor in Factories in v22? It's good that it makes it simpler again but would need a little more balancing first imo |
well, factories are basically dead if we do this |
Factories were supposed to lessen the impact of being landlocked. Don't think we can simply remove them. Maybe they need a buff to compensate, while keeping it simple |
If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #(issue number)
Description:
Describe the PR.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
DISCORD_USERNAME