Skip to content

A dream about fbos summing using += operator #7130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimitre wants to merge 7 commits into
base: master
Choose a base branch
from
+10 −0
Open

A dream about fbos summing using += operator #7130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d64e53c
dream operator fbo +=
dimitre Oct 6, 2022
60a7ccc
undo Makefile changes
dimitre Oct 6, 2022
0ae1d62
not mom really
dimitre Oct 6, 2022
0dfe763
removing ofSetColor
dimitre Oct 6, 2022
ac8076a
fbo isAllocated check
dimitre Dec 8, 2022
8eeff2d
consistent args
dimitre Dec 8, 2022
b3469e3
Merge branch 'openframeworks:master' into dream
dimitre Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions libs/openFrameworks/gl/ofFbo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,15 @@ ofFbo::ofFbo(const ofFbo & mom){
}
}

//--------------------------------------------------------------
void ofFbo::operator+=(const ofFbo & fbo){
if (fbo.isAllocated()) {
this->begin();
fbo.draw(0,0);
this->end();
}
Copy link
Copy Markdown
Member

@ofTheo ofTheo Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like it should be something like:

	//if we aren't allocated lets allocate to be the same as the input
	if (!this->isAllocated() && fbo.isAllocated()) {
 		this->allocate(fbo.settings); 
 	}
	if (fbo.isAllocated()) {
 		this->begin();
 		fbo.draw(0,0);
 		this->end();
 	}else{
 		ofLogWarning("ofFbo::operator+=") << " input fbo is not allocated, skipping += ";
 	}

Copy link
Copy Markdown
Member

@ofTheo ofTheo Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimitre what do you think about the suggestion above?👆

This way it basically copies the fbo being += if the main fbo isn't allocated

}

Copy link
Copy Markdown
Member

@ofTheo ofTheo Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to add a check that if the fbo isn't allocated you can an error/warning
or you could have if it is not allocated it gets allocated to match first?

//--------------------------------------------------------------
ofFbo & ofFbo::operator=(const ofFbo & mom){
if(&mom==this) return *this;
Expand Down
1 change: 1 addition & 0 deletions libs/openFrameworks/gl/ofFbo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class ofFbo : public ofBaseDraws, public ofBaseHasTexture {
ofFbo();
ofFbo(const ofFbo & mom);
ofFbo & operator=(const ofFbo & fbo);
void operator+=(const ofFbo & fbo);
ofFbo(ofFbo && mom);
ofFbo & operator=(ofFbo && fbo);
virtual ~ofFbo();
Expand Down