Add faas-cli diag documentation to troubleshooting page#418
Open
welteki wants to merge 1 commit intoopenfaas:masterfrom
Open
Add faas-cli diag documentation to troubleshooting page#418welteki wants to merge 1 commit intoopenfaas:masterfrom
welteki wants to merge 1 commit intoopenfaas:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
alexellis
reviewed
Mar 9, 2026
alexellis
reviewed
Mar 9, 2026
alexellis
reviewed
Mar 9, 2026
alexellis
reviewed
Mar 9, 2026
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewSummary
Approval rating (1-10)3 Summary per fileSummary per file
Overall AssessmentThe PR introduces documentation for a new diagnostic tool but contains a critical error with an incomplete sentence. The replacement of the config checker section without clear migration guidance raises concerns about user disruption. The embedded asciinema with autoplay may negatively impact user experience. Detailed ReviewDetailed ReviewIncomplete sentence in new section
Replacement of config checker
asciinema embedding concerns
Potential security implications
Consistency with existing documentation
Missing error handling guidance
Date format in example
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for the
faas-cli diagtool to the troubleshooting page. The section covers installation, configuration, and running diagnostics. An asciinema recording is embedded to demonstrate the tool in action.Motivation and Context
Add a dedicated section to the troubleshooting page for the new
faas-cli diagplugin.How Has This Been Tested?
The site has been run locally with docker and verified everything is displayed correctly.
Types of changes
Checklist:
git commit -s