Do not include node_modules or vendor directories.

docs/openfaas-pro/jetstream.md

• Queue Mode Section: The new "Queue mode" section effectively explains the distinction between static and function modes. The YAML configuration examples are clear and well-formatted. The inactiveThreshold parameter is appropriately documented with a code example. However, consider adding a migration note for existing users upgrading from static to function mode, including any potential downtime or configuration validation steps.

• Adaptive Concurrency Section: This new section provides excellent coverage of the feature's purpose, mechanism, and configuration. The example with the sleep function is particularly helpful for understanding real-world application. The explanation of how it handles 429 responses and adjusts concurrency is technically accurate. Consider adding metrics or monitoring guidance for observing adaptive concurrency behavior in production.

• Queue-based Scaling: The rewrite clarifies that this requires function mode, which is good. The link to /reference/autoscaling/ should be verified to ensure it points to the correct section on queue-depth scaling.

• Content Removal: Removing async use-cases from this page improves focus on queue-worker specifics. The moved content to async.md is appropriate.

• Consistency: The YAML examples use consistent formatting. However, the adaptiveConcurrency: false example could benefit from showing it within the full jetstreamQueueWorker block for clarity.

• Potential Risks: Function mode creates dedicated consumers per function, which could impact NATS resource usage at scale. Consider adding guidance on monitoring NATS consumer counts and potential limits.

docs/reference/async.md

• Added Content: The moved async use-cases and blog references fit well in this reference page. The content enhances the async invocation documentation without disrupting flow.

• Retries Reference: Updating the retries bullet to point to /openfaas-pro/retries is appropriate, but verify this link exists and is accurate.

• Overall: The additions strengthen this as a comprehensive async reference. No major issues detected.

General Concerns

• Link Validation: All internal links (e.g., /reference/async, /reference/autoscaling/, /openfaas-pro/retries) should be tested to ensure they resolve correctly in the built documentation.

• Enterprise Features: The documentation correctly marks function mode and adaptive concurrency as enterprise features. Ensure pricing links are current.

• Testing: While local testing with Docker is mentioned, consider adding a note about testing links in the built site to catch any broken references.

• Backward Compatibility: The reorganization may break bookmarks or direct links to sections that moved. Consider adding redirects or update notices if this documentation has external users.

• Security/Performance: As documentation, no direct security concerns. The features documented (adaptive concurrency) aim to improve performance by preventing unnecessary retries, which is positive.

• Consistency with Codebase: The YAML configurations match typical OpenFaaS patterns. No issues with using strings for modes instead of constants, as this is configuration.

Recommendations

1. High priority: Verify all internal links in the updated documentation.
2. Medium priority: Add brief migration guidance for users enabling function mode.
3. Low priority: Consider adding monitoring recommendations for NATS consumers when using function mode.