Conversation
I am not confident that this was really tested - looking at the change, I don't think that this can end in anything else but a fatal QA error. (Edit: I missed that it's scarthgap, which shouldn't end with error, but there should be a warning about the same issue - regardless, please fix) After fixing that, could you please squash these commits, add a descriptive commit message about the issue this is solving, and prefix the commit subject with the recipe name? As a somewhat related question, if this is about the location of files, is it really a bug in the frr-reload script, and not a problem with the recipe that installs it to an incorrect location? (The patch essentially might be correct as it is, I'm just looking for some clarity) |
|
I do not understand the claim regarding a fatal QA error. The location of executable files in /usr/libexec/frr is appropriate; after all, it concerns scripts, not libraries. This is not a bug in the frr-reload.sh script, but rather a misalignment with the Autotools configuration process. |
|
I'm referring to the It might be a waste of time to fix it other way, but it would be useful to add some note about it in the commit message and maybe in the patch also: what's the actual problem, and why it is better to solve it like that. It doesn't need to be a long essay, but leaving it out will just people scratching their head. |
| -if test -e /usr/lib/frr/frr-reload.py; then | ||
| - exec /usr/lib/frr/frr-reload.py --reload /etc/frr/frr.conf | ||
| +if test -e /usr/libexec/frr/frr-reload.py; then | ||
| + exec /usr/lib/frrexec/frr-reload.py --reload /etc/frr/frr.conf |
There was a problem hiding this comment.
Should this not be /usr/libexec/frr/frr-reload.py also just like the path in the test one line above also?
Update tools/frr-reload to reference frr-reload.py in the correct location (/usr/libexec/frr/ instead of /usr/lib/frr/). Add corresponding patch to the recipe build process. Signed-off-by: Slawomir Blaszczyk <bslawomir330>
bslawomir330
force-pushed
the
bslawomir330-patch-1
branch
from
a8a07a0 to
65b21c6
Compare
|
Thank you for your patience. I believe I have implemented the requested adjustments. |
2 participants
FRR frr-reload.py path update to /usr/libexec/frr/
Summary
This pull request updates the FRR (FRRouting) recipe to use the correct path for
frr-reload.pyin/usr/libexec/frr/instead of/usr/lib/frr/.Changes
0002-tools-update-frr-reload.py-path-to-usr-libexec-frr.patchtools/frr-reloadscript to look forfrr-reload.pyin/usr/libexec/frr/frr_9.1.3.bbrecipe to include the new patch in the build processDetails
meta-networking/recipes-protocols/frr/frr_9.1.3.bbTesting
Please verify that:
frr-reload.pyscript is correctly located and executable in/usr/libexec/frr/