Skip to content

chore: Update default start date to January 1, 2040#38277

Merged
feanil merged 2 commits intomasterfrom
feanil/push_default_start_date
Apr 11, 2026
Merged

chore: Update default start date to January 1, 2040#38277
feanil merged 2 commits intomasterfrom
feanil/push_default_start_date

Conversation

@feanil
Copy link
Copy Markdown
Contributor

@feanil feanil commented Apr 2, 2026

Push this forward so things don't automatically in a few years for future courses.

@feanil feanil marked this pull request as draft April 2, 2026 18:08
@kdmccormick
Copy link
Copy Markdown
Member

kdmccormick commented Apr 2, 2026

For posterity:

  • We know this is a bad fix, but we don't have time to do the right fix, and we want to merge this now in order to reduce the number of courses that will surprise-start on 1/1/2030.
  • We don't want to push it out to like 1/1/2099 because the user has to page through datepicker UI to choose a start date
  • The right fix would probably involve making start nullable, or having a separate available boolean field
    • Or, defaulting the start today to (date.today() + 1 year)
  • We know that a bunch of courses will start on 1/1/2030 regardless of this PR
  • We discussed doing a data migration between now and 1/1/2030, which checks to see if the start date is exactly 1/1/2030 or 1/1/2040 and, if it is, changing it to like (date.today() + 5 years) and raising a warning to the operator

Push this forward so things don't automatically in a few years for future courses.
@feanil feanil force-pushed the feanil/push_default_start_date branch from 6a5038b to 0d66a2f Compare April 11, 2026 17:10
…RT_DATE

Tests were asserting against the literal `2030-01-01` value instead of
importing the constant, causing failures after the default was updated to 2040.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@feanil feanil force-pushed the feanil/push_default_start_date branch from 0d66a2f to d4b5570 Compare April 11, 2026 18:24
@feanil feanil marked this pull request as ready for review April 11, 2026 21:09
@feanil feanil merged commit 9beb657 into master Apr 11, 2026
52 checks passed
@feanil feanil deleted the feanil/push_default_start_date branch April 11, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants