Skip to content

feat: replace enterprise_support import with AccountSettingsReadOnlyFieldsRequested filter#38098

Open
pwnage101 wants to merge 9 commits intomasterfrom
pwnage101/ENT-11510
Open

feat: replace enterprise_support import with AccountSettingsReadOnlyFieldsRequested filter#38098
pwnage101 wants to merge 9 commits intomasterfrom
pwnage101/ENT-11510

Conversation

@pwnage101
Copy link
Copy Markdown
Contributor

@pwnage101 pwnage101 commented Mar 4, 2026

Removes the direct import of get_enterprise_readonly_account_fields from openedx.features.enterprise_support.utils in accounts/api.py and replaces it with a call to the AccountSettingsReadOnlyFieldsRequested openedx-filter. Adds the filter to OPEN_EDX_FILTERS_CONFIG. Updates tests to mock the filter instead of the old enterprise_support imports.

ENT-11510

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com


Blocked by:

…ieldsRequested filter

Removes the direct import of get_enterprise_readonly_account_fields from
openedx.features.enterprise_support.utils in accounts/api.py and replaces it
with a call to the AccountSettingsReadOnlyFieldsRequested openedx-filter.
Adds the filter to OPEN_EDX_FILTERS_CONFIG. Updates tests to mock the filter
instead of the old enterprise_support imports.

ENT-11510

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pwnage101 pwnage101 added the enterprise An enterprise-related change label Mar 18, 2026
@kiram15 kiram15 marked this pull request as ready for review April 6, 2026 19:22
@kiram15 kiram15 requested review from a team, feanil and kdmccormick as code owners April 6, 2026 19:22
@kdmccormick kdmccormick removed their request for review April 6, 2026 19:33
@kiram15 kiram15 force-pushed the pwnage101/ENT-11510 branch 4 times, most recently from cb1fa6e to 7c9264c Compare April 6, 2026 22:45
@pwnage101
Copy link
Copy Markdown
Contributor Author

pwnage101 commented Apr 7, 2026

Some notes on requirements for platform:

  • openedx/openedx-platform uses python 3.12 to run make upgrade, while edx/edx-platform (2U fork) uses 3.11. You need both python versions available to upgrade requirements for both separately.
  • We added social-auth-app-django as a hard dependency on the edx-enterprise python package, so it makes sense that pip-tools wants to mark edx-enterprise as wanting it. Often you can fix this automatically using compile-requirements if you just want to limit what gets upgraded and fix the comments only:
# openedx/openedx-platform
pyenv local 3.12.13
make compile-requirements

# edx/edx-platform
pyenv local 3.11.14
make compile-requirements

@kiram15 kiram15 force-pushed the pwnage101/ENT-11510 branch from 0deab07 to 86db1d4 Compare April 7, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enterprise An enterprise-related change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants