Skip to content

Conversation

@BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Feb 24, 2025

Description

This PR installs and configures scriv to manage the changelog file.

This PR is based on the Tutor repository configuration.

Testing instructions

You can test the scriv commands running their corresponding Makefile commands:

  • make changelog-entry (Run scriv create): This command will create a file in the changelog.d folder. You must edit it to describe your changes. This file must be committed. The contributor should use this command in each PR with changes.

  • make changelog (Run scriv collect): This command will update the CHANGELOG. The previous files in the changelog.d will be removed and their content will be added in the CHANGELOG. This command only should be used in the release.yml workflow by a maintainer.

Deadline

None

Other information

Checklists

Check off if complete or not applicable:

Merge Checklist:

  • All reviewers approved
  • Reviewer tested the code following the testing instructions
  • CI build is green
  • Version bumped
  • Changelog record added with short description of the change and current date
  • Documentation updated (not only docstrings)
  • Integration with other services reviewed
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post Merge:

  • Create a tag
  • Create a release on GitHub
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)
  • Upgrade the package in the Open edX platform requirements (if applicable)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 24, 2025

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/committers-openedx-events.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@BryanttV BryanttV marked this pull request as ready for review February 25, 2025 15:43
@BryanttV BryanttV requested a review from a team February 25, 2025 15:43
@mariajgrimaldi
Copy link
Member

We're working on a review here first: openedx/openedx-filters#268

@mariajgrimaldi mariajgrimaldi marked this pull request as draft March 14, 2025 09:10
@BryanttV BryanttV force-pushed the bav/scriv branch 2 times, most recently from dbe3e62 to ed72de1 Compare March 19, 2025 04:03
@BryanttV BryanttV force-pushed the bav/scriv branch 2 times, most recently from 44c35f0 to 0ff7884 Compare April 14, 2025 18:50
@mphilbrick211
Copy link

Hi @BryanttV! Is this pull request still in progress?

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Sep 12, 2025
@BryanttV
Copy link
Contributor Author

Hi @mphilbrick211! Thanks for the ping.

@mariajgrimaldi, the PR that migrates to scriv in openedx-filters has already been merged. Should we do the same here, or do you think we need to address the changes in openedx/openedx-filters#284 first?

@mphilbrick211
Copy link

Hi @mphilbrick211! Thanks for the ping.

@mariajgrimaldi, the PR that migrates to scriv in openedx-filters has already been merged. Should we do the same here, or do you think we need to address the changes in openedx/openedx-filters#284 first?

Friendly ping on this, @mariajgrimaldi!

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Nov 6, 2025
@BryanttV
Copy link
Contributor Author

BryanttV commented Dec 1, 2025

This PR will remain in Draft until the complete flow in openedx-filters is ready, so that it can be replicated here.

@mphilbrick211 mphilbrick211 removed the inactive PR author has been unresponsive for several months label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

4 participants